LegendOfMCPE / EssentialsPE

Port of Bukkit Essentials for @PocketMine Servers (Moved to @poggit-orphanage)
GNU General Public License v3.0
99 stars 21 forks source link

/tpa teleports the other player to you instead of vice versa #234

Closed Skyladd closed 7 years ago

dktapps commented 8 years ago

Confirmed this issue with newest commit (still!)

Sandertv commented 8 years ago

Aware of this problem and looking for a fix.

Infernus102 commented 8 years ago

still not fixed

Sandertv commented 8 years ago

I know, didn't find out what the problem is yet, sorry.

Sandertv commented 8 years ago

I think I found out... Let me try to test if that is the problem.

Sandertv commented 7 years ago

It should be fixed. I do not recommend updating yet, I'll test it first.

Infernus102 commented 7 years ago

did you test it?

Sandertv commented 7 years ago

Yeah it didn't fix it yet. I think I found out what the problem is, I just have to find a clever way to fix it.

Sandertv commented 7 years ago

You could update though, /tpa works good now, just /tpahere is reversed now.

Infernus102 commented 7 years ago

Why is this so hard? Even experts cant solve this?

Sandertv commented 7 years ago

The way you get the information whether it is a tphere or tpa request is hard to obtain if you don't know who the sender was when doing /tpaccept. It's saved in a way you need the requester's name to find out what the request was. So I have to find a good way for it.

Sandertv commented 7 years ago

I think it might in fact work right if you would add the name of the requester in your tpaccept, for example: /tpaccept steve

Infernus102 commented 7 years ago

But that would be boring

Sandertv commented 7 years ago

Yep, that's why I still have to find a good way to fix it.

Sandertv commented 7 years ago

Could you try it with the latest commit? It might work.

Infernus102 commented 7 years ago

i am working on something else, sorry :( will take me some time!

Sandertv commented 7 years ago

Any results yet @Infernus102 or someone else?

Infernus102 commented 7 years ago

can't confirm, i made my own /tpa and /tpahere

Sandertv commented 7 years ago

Ah okay, I'll try and check myself.

Sandertv commented 7 years ago

It seems in fact that it is all working! After like a year of this not working I finally fixed it!

Sandertv commented 7 years ago

It works as of this commit: 2e5394d2b942193ee694455fdb8fcf6bdcd16b72

Infernus102 commented 7 years ago

SanderFTW 👍 🙌