Legends-of-Azeroth / Legends-of-Azeroth-Pandaria-5.4.8

Legends-of-Azeroth-Pandaria-5.4.8
https://legends-of-azeroth.github.io/Legends-of-Azeroth-Pandaria-5.4.8/
GNU General Public License v2.0
51 stars 50 forks source link

🐛 [Bug]Feign Death is ineffective #280

Open ctmwow opened 1 month ago

ctmwow commented 1 month ago

When using feign death, character movement will not cancel the feign death aura and state; If feign death is used in combat, the feign death aura and status will be automatically cancelled.

jasongdove commented 1 month ago

character movement will not cancel the feign death aura and state;

This should be fixed with #281

If feign death is used in combat, the feign death aura and status will be automatically cancelled.

I'm not familiar with Hunter behavior; it looks like you have to manually stop attacking before casting feign death for it to work on the current build. Is that behavior incorrect?

ctmwow commented 1 month ago

Find a training dummy, attack it to enter in combat, and then cast Feign Death, You will find that the character automatically stands up and continues shooting at the target.

jasongdove commented 1 month ago

The SMSG_CANCEL_AUTO_REPEAT packet is wrong, and there are other things that should be improved with auto repeat. I will fix.