LegendsOfSky / PearlCalculatorCore

Just A Pearl Calculator Core Project Attempt
MIT License
21 stars 3 forks source link

[Bug] Lib issues the calculation is incorrect #5

Closed whats2000 closed 3 years ago

whats2000 commented 3 years ago

1 This a picture about the real testing result in 1.16.5 The thest in world result tick = 2 pos is at (1000.5826506180033, 150.81874999590218, 0) The result from the calculator tick = 2 pos is at (1000.582650618024, 150.8484517986487, 0) 2 Here is the setting I test. 3 The test device I use with 3 command block First one command is "script run loop(727,run('summon tnt -0.02 161 -0.02 {Motion:[0d,-10d,0d]}'))" Second one command is "script run loop(727,run('summon tnt -0.02 161 0.02 {Motion:[0d,-10d,0d]}'))" Third one command is "summon ender_pearl 0.0 150.84874999523163 0.0" using carpet mod and extra to test

LegendsOfSky commented 3 years ago

Report Rejected. Reason : This reporter had not faced the problem himself.

LegendsOfSky commented 3 years ago

Further Description : This reporter is reporting issues others find and information might have been missing or distorted through a third person. Therefore, this issue will be closed soon unless the problem founder comment here. image

lntricate1 commented 3 years ago

Ok hello, i experienced the issue. I think the error is that the game is written in Java and has a lot of casting to double and float which causes errors, but the lib is not in java so it doesn't have the same errors. One fix could be changing the pearl eyes from 0.25 * 0.85 to 0.2125000059604645.

whats2000 commented 3 years ago

unknown Here is the data using 0.2125000059604645 (same setting)

lntricate1 commented 3 years ago

Yeah, that new data looks very good, I think it did fix it.

LegendsOfSky commented 3 years ago

Issue Confirmed. The eye height will be changed to a constant 0.2125000059604645 soon. Thanks for the report. Note : This Thread won't be close in 7 days unless a MCP check is finished.

lntricate1 commented 3 years ago

Also, since you will change the pearl eye height, you should also add some missing decimals to the TNT height. It's actually not 0.0612500011921, it's 0.061250001192092896 (this is (double)0.98F*0.0625D)

LegendsOfSky commented 3 years ago

MCP Check finished. Result are correct in the same input. Typical use should have a precision in 12 digits. Digits after 12 might not be correct due to the way we normally obtain information. Note : This Issue will be closed soon.

LegendsOfSky commented 3 years ago

To Intricate : Before this Issue close, I want to apologize about the inconvenience caused by the Bug Report Rules. The rules is used to prevent any information missing or distortion in transmitting.

It happened in discord. At that moment, whats2000_ is sending your report to me, but most of the information were lost and resulting a hard time in guessing what reporters actually means and why this issues comes without any device to reproduce the whole problem. Therefore the rules has been setup and we need you to report for the issue.

I am very apologize for the inconvenience in reporting any Bugs. I hope you will understand. Thanks for helping us to make this project a much better.

memorydream commented 3 years ago

close this issue beacuse it fixed and new version released

memorydream commented 3 years ago

you might need to check about the value of Pearl Y Coordinate in settings which had changed from 170.34722638929408 to 170.34722638929412