Closed bombsimon closed 11 months ago
Awesome thanks for finding this, I assumed there will be bugs with the refactor. Will merge 👍
Thanks for the super quick turnaround!
I was a bit quick myself with this PR and had not really explored the code fully. Although it will not be an issue and still work I noticed that the methods to set these values are still int
: https://github.com/Leggin/dirigera/blob/88b50652b076d4a8715cf91c88f1ac408c6c2f41/src/dirigera/devices/light.py#L77
Just a heads up if you want to squeeze that in in your next PR :) And of course if you want me to I can PR that as well.
Good catch! The CI should have caught this. I will check this.
IKEA lights that has color support may return the hue as a float. To support this the type on the class must match that.
Thanks for an amazing project!
I just discovered the project and it was super easy to get up and running, however the first thing that happened to me was that I hit an issue with the Pydantic validation. I have a light with color support and the Dirigera will return the
color_hue
as a float:I only have one of these bulbs (it's a couple of years old) so I don't know if it's unique for this, the old version or something else, however since it obviously can happen I think the value for the hue should be represented as a float. With this fix, this is the output for my lights: