LegionDark / Issues

[ARCHIVE] Issue tracking for the LegionDark private server.
10 stars 76 forks source link

Augments Composure effect on Estoqueur's Armor Set +2 #1610

Open xrocksterx opened 7 years ago

xrocksterx commented 7 years ago

Date & Time: 08/10/2017 11:45am pst

FFXI Client Version (use /ver): 30170707_0

Server's Expected Client Version matches, yes/no? (use $ecv): yes

Character Name: Fenom

Nation: San D'oria

Job(level)/Sub Job(level): 99RDM/49WHM

NPC or Monster or item Name: Augments Composure on Estoqueur's Armor Set +2

Zone name: Abyssea Konschtat

Coordinates (use $where): X:38 Z:628 (49)

ffxiah.com link (for items issues only): http://www.ffxiah.com/item/11068/estq-chappel-2 http://www.ffxiah.com/item/11088/estq-sayon-2 http://www.ffxiah.com/item/11108/estq-ganthrt-2 http://www.ffxiah.com/item/11128/estqr-fuseau-2 http://www.ffxiah.com/item/11148/estq-houseaux-2

http://www.ffxiah.com/item/16204/estoqueurs-cape

Multi-boxing? (multiple clients on same connection): yes

Steps To Reproduce / any other info: Equipped all 5 Estoqueur +2 Armor Set to fully test, turned off gearswap so that the gear stays on fulltime. Activated composure. Cast Haste on party member, still had the original 3min timer. Cast Haste2, still 3min. Cast Regen2, still same 1min timer. these are the only spells I have tested and none are showing extended durations as they should with the augments composure empyrean gear bonus.

I'm not sure if Estoqueur's Cape is increasing the enhancing magic duration either, but i had that equipped too.

TeoTwawki commented 7 years ago

Gotta remember that in 99% of these cases its simply because it doesn't exist in darkstar yet.

I think this needs a new modifier so EFFECT_COMPOSURE can check for said mod, then placing of the modifier boost in \globals\gear-sets.lua

Edit: Oh, annoying...Things just check for if you even have composure:

https://github.com/DarkstarProject/darkstar/blob/824fbbd7c79eea6d43524c0d96131abffac56881/scripts/globals/spells/baramnesra.lua#L29

if (caster:hasStatusEffect(EFFECT_COMPOSURE) == true and caster:getID() == target:getID()) then
    duration = duration * 3;
end

They would also need to check a value stored by the effect instead of that. So every thing effected by composure would need to be edited in addition to what I said before the edit.

This may take awhile..I don't have time to do it myself today and ppl tend to not volunteer for anything that makes them edit 20+ things

w3genesis commented 7 years ago

Wow so the modifier for Estoqueur set bonus (and probably Lethargy set by extension) doesn't even exist... Good thing I was too lazy to kill the hundreds of reforged mobs to make rdm 119 armor... O_O

TeoTwawki commented 7 years ago

rdm main mself...dem feels

tb1 commented 6 years ago

None of the stuff that increases enhancing spell duration works (no mod for it). A few other pieces could use it, and I'd assume having the lethargy set bonus just increase the mod potency would be the way to go (haven't looked at the mod implementation close enough to say for sure)