LegionDark / Issues

[ARCHIVE] Issue tracking for the LegionDark private server.
10 stars 76 forks source link

Gear/Spell haste cap not applied to recast #1796

Open tb1 opened 6 years ago

tb1 commented 6 years ago

Date & Time: Jan 23, 2018

FFXI Client Version
(use /ver to see your version)
:

Server's Expected Client Version matches?
(use !ecv to see expected version)
(THIS IS A YES OR NO QUESTION!)
:

Character Name: Tbone

Nation: Windy

Job(level)/Sub Job(level): Whatever

NPC or Monster or item Name:

Zone name:

Coordinates (use !where):

ffxiah.com link (for items issues only):

Multi-boxing? (multiple clients on same connection):

Steps To Reproduce / any other info:

https://github.com/DarkstarProject/darkstar/blob/459685fa63386640ffaa8759f61b76dae3973d29/src/map/utils/battleutils.cpp#L5113

Mod::HASTE_GEAR and Mod::HASTE_MAGIC don't get capped when set, and aren't being capped when applied to recast (they are to weapon delay however).

The hard cap of 80% is being applied at

https://github.com/DarkstarProject/darkstar/blob/459685fa63386640ffaa8759f61b76dae3973d29/src/map/utils/battleutils.cpp#L5150