LegoCreation / CNN_eddy_detection

4 stars 1 forks source link

3 in input data? #1

Open vasmue opened 1 year ago

vasmue commented 1 year ago

https://github.com/LegoCreation/CNN_eddy_detection/blob/4b83f105650bc554fc46ea508a07ed71dffd03d7/scripts/cnn_training.py#L68

Max noticed that sometimes there are 3's in the seg mask. Seems like you also had this problem. Any idea why?

LegoCreation commented 1 year ago

I didn't have those problems when I tried those. I create those lines just to be extra sure.

vasmue commented 1 year ago

https://github.com/LegoCreation/CNN_eddy_detection/blob/4b83f105650bc554fc46ea508a07ed71dffd03d7/scripts/generate_segmentation_mask.py#L71C57-L71C57

looks like it comes from here. If both masks are 1, then the result will be 3

LegoCreation commented 1 year ago

3 is possible if you have both anticylonic and cyclonic eddy pixel at the same spot.

vasmue commented 1 year ago

Yes, exactly this. But it should theoretically never happen (eddy can't be both), so I am a bit confused why py-eddy-tracker does it sometimes.