LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
166 stars 58 forks source link

Adds configuration for emoji + square shiny detection #105

Closed ViolentSpatula closed 1 year ago

ViolentSpatula commented 1 year ago

Add emoji to save data Add emoji config button to settings/webhook Add EmojiConfig popup window Add Square Shiny filter (filter tested and working) Add Square Shiny detection to webhook (temp emoji is literally garbage)

image image image image

architdate commented 1 year ago

Love the emoji config, but why do we care about square vs regular shinies here? only SWSH differentiates the shiny type, since then visually both shinies have been the same.

ViolentSpatula commented 1 year ago

It's been a common request so I added it, most people that want it care about it for home/the future games.

jnovack commented 1 year ago

I have quite a number of garbage shinies. Now I want garbage SQUARE shinies!

jnovack commented 1 year ago

That square is just still too confusing. It looks like the icon didn't load.

image
ViolentSpatula commented 1 year ago

It's a placeholder emoji meant to be changed (in code, not just the user changing it). It's not meant to stay like that.

With the emoji config you could literally change it to say "Square Shiny" or "cheeseburger" if you like :growlshrug:

jnovack commented 1 year ago

so, I caught what was calculated as a square shiny, but it did not square when I threw him into a raid.

can anyone confirm they actually have a square shiny?

pifopi commented 1 year ago

"only SWSH differentiates the shiny type, since then visually both shinies have been the same." They're square only in your own mind, if you transfer them to swsh or if they revive this later on.

Very neat changes, I loved the emotes before the rollback !

architdate commented 1 year ago

They're square only in your own mind

image

Very neat changes, I loved the emotes before the rollback !

I believe you can add them back with this change (just copy over the older emote strings and it should work)