search

LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
166 stars 58 forks source link

Feature/graceful stop #121

Closed lfmundim closed 1 year ago

lfmundim commented 1 year ago

Issue:

I sometimes am crawling but I need to stop and nothing was found so far, so the bot is still running. If I click "Disconnect" the app gets angry at me throwing an exception.

image

Solution:

To mitigate that I added a "Stop" button (with a tooltip) that will immediately stop the advancing loop. The same behavior is now applied to the "Disconnect" button as well.

I had to move the UI around a bit to accommodate the new button

image

Issue 2 of #114

jnovack commented 1 year ago

Rather than move the UI around, merge the locations of the "Connect/Disconnect" buttons, and put stop in Disconnect's location.

Connect/Disconnect are never active at the same time, they are wasting space.

lfmundim commented 1 year ago

Rather than move the UI around, merge the locations of the "Connect/Disconnect" buttons, and put stop in Disconnect's location.

Connect/Disconnect are never active at the same time, they are wasting space.

that would leave Advance/Stop separate, from a UX POV that is not very intuitive though is it?

jnovack commented 1 year ago

Excellent point. I'm just against changing the size of the window and existing elements. Perhaps moving the "Shiny" number? it's weird there.

lfmundim commented 1 year ago

Any chance this is being considered by the owner? If so I'll resolve the conflict

LegoFigure11 commented 1 year ago

Superseded by #137