Fix: Tera Shards improperly showing type

LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet

GNU General Public License v3.0

168 stars 59 forks source link

Fix: Tera Shards improperly showing type #139

Closed d-pollard closed 1 year ago

d-pollard commented 1 year ago

Info

I noticed tera shards were off for events and even sometimes normal raids; after a bit of debugging, realized raid.TeraType wasn't always correct but Raid.GetTeraType() is

Before fix:

After fix:

LegoFigure11 commented 1 year ago

Thanks! @Koi-3088 is this going to interfere with #137 at all?

Koi-3088 commented 1 year ago

Probably, given how much my draft PR touches. Don't mind me though. If you'd like a quick fix for nightly, I don't mind having to potentially rebase, conflict solve, and force-push to preserve commit history.

As far as my PR goes, I'm hoping to marking it as ready this Friday or Saturday. Since it's already huge, I'm just testing and writing minor fixes instead of refactoring even more. Will reserve the latter for the future.

LegoFigure11 commented 1 year ago

Noted, thanks!