LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
166 stars 58 forks source link

Filter not always working for the Ditto event. #145

Closed ruanick closed 1 year ago

ruanick commented 1 year ago

I have a save file that hasn't connected to the internet since the event and still has the Ditto raids. I set up filters for 0 Attack and 0 Speed Ditto but have noticed they don't always trigger. This is happening on the current nightly build, v1.1.1-3b15e09.

I've attached screenshots of a save with two 31/00/31/31/31/31 Ditto raids on the map while RaidCrawler says 0 matches. I went and captured the adamant one to confirm it was 31/00/31/31/31/31.

The third screenshot is from clicking "Advance Date" immediately after the above where a 31/31/31/31/31/00 Ditto was successfully identified by the filter. From what I can tell the two filters were configured identically except for the position of the 0 IV.

I can provide a save from before I captured the adamant one if it's helpful. I changed the extension of my filter.json to filters.txt so I could attach it here.

filters.txt bug bug2 bug4

Koi-3088 commented 1 year ago

Pushed a commit that should hopefully fix it. Let me know if it works.

ruanick commented 1 year ago

Thanks for the update, it seems to have resolved some of the issue. I loaded the previously mentioned save and set the system date to preserve the dens. RaidCrawler immediately identified the two matching dens that it missed before.

I started advancing one day at a time and manually verifying the filters to see if it would miss any. First Skip: Failed to identify a 0 Spd Ditto. Second Skip: Succeeded in identifying a 0 Atk Ditto. Third Skip: Succeeded in identifying a 0 Spd Ditto. The filters worked correctly for the 4th and 5th skips. Sixth Skip: Failed to identify a 0 Spd Ditto.

I made a save back-up after the sixth skip and will continue skipping later to see if it still misses any 0 Atk. I probably should have left the Shiny filter off during testing but I clicked though all of the dens to confirm that the matching instances correctly referred to Dittos and nothing else.

Edit: Sorry, I misclicked the Close issue button!

fixed1 spdbug workingatk workingspd spdbug2

Koi-3088 commented 1 year ago

Thank you for testing and noticing, try out the latest commit once it finishes building.

ruanick commented 1 year ago

It looks like that did the trick. I loaded the 0 Spd Ditto save from the previous test and RaidCrawler identified a match. I checked 15 days and every 0 Atk and 0 Spd Ditto was correctly identified.

Thanks for the help! fixed