search

LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
168 stars 59 forks source link

Fix for Issue #163 #167

Closed CardBreaker closed 1 year ago

CardBreaker commented 1 year ago

Added missing den locations. I found these by temporarily modifying RC to stop when it found a den without a location then ran it until I went 300 skips without a missing location. Curiously, the Apple Hills locations that I found for 2-1-1X seem to exactly match the 2-2-X entries. I kept these in since I'm not sure about if the display type 2 entries are used and since it doesn't hurt for them to exist and go unused.

kwsch commented 1 year ago

Per latest PKHeX commit, the "display type" is just a "lottery group".

Raid Crawler isn't reading the Raid Point tuple correctly; the points from the ROM should be correct.

LegoFigure11 commented 1 year ago

Fixed by 635061fb, but thank you for the PR regardless!

Lusamine commented 1 year ago

To clarify what happened for posterity: The original raid point tuples (area-lotterygroup-location) were added based on strings dumped from the game. image

As you noted, the Kitakami 2_1_x points seemed to continue past 10, and when we tested, the 2_2_x points didn't work at all. The assumption was that the original string descriptors were incorrect, but the coordinates were correct, so the best fix was simply to re-label the points correctly and keep the dumped coordinates.