LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
168 stars 59 forks source link

On reset, advance the day and save (#169) #171

Closed CardBreaker closed 1 year ago

CardBreaker commented 1 year ago

Adds an advance and save after game reset to avoid rescanning raids.

CardBreaker commented 1 year ago

Per my comments on #169 I went with the most efficient approach of saving prior to the reset. Saving will still fail if lag gets too intense, but I'm treating that as a user config issue, and skips per reset should be reduced if the user is having lag induced issues.

I also handled a separate bug that would occur if you found a match with save on match turned on, didn't care for it, and started advancing again. This issue occurs when you don't find another match before the next reset, the reset occurs, and the first scan fails. RC would then consider that skip a success since the previous raids were from before the reset and are different from the raids after the reset. It will then stop the program since the match that was previously found will be matched again. This is fixed by reading raids after the reset but before the first advance.

LegoFigure11 commented 1 year ago

Thanks!