LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
169 stars 59 forks source link

Duplicate Result Issue (?) #43

Closed ReZeroEmiria closed 1 year ago

ReZeroEmiria commented 1 year ago

Sometimes when I use "advance date", the program will produce the same raid results in the next check or in a few checks later.

I'm sure this is probably something like a seed being reused in game and probably not a "bug" per say but I was wondering if you could implement a feature that records the last time the program "completed" and if it gets this result again consecutively it will not stop and continue until the next filter or result that triggers a "completed" is different than the last ?

architdate commented 1 year ago

This happens when the seeds dont change during the faux date change action. Your proposed solution can be implemented fairly easily to remedy this, however its best to store seeds themselves instead of a duplicate list of raid objects to save up on space

LegoFigure11 commented 1 year ago

Simply storing the firs seed in the list should be sufficient, I'm happy to live with missing the 1/4bn that they're the same

architdate commented 1 year ago

Simply storing the firs seed in the list should be sufficient, I'm happy to live with missing the 1/4bn that they're the same

oops too late lol