LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
168 stars 59 forks source link

East Province (Area 1) - Den 2 has bad location markers #92

Closed jnovack closed 1 year ago

jnovack commented 1 year ago

Describe the bug East Province (Area 1) - Den 2 is listed on both the east and west of the map. The left-most icon is definitely wrong, and the right-most icon is in the wrong province (it is in Area 2).

To Reproduce If applicable, please list the steps to reproduce the behavior:

  1. Get a match for 'East Province (Area 1) - Den 2
  2. Open Map

Screenshots image

image

The correct location is the Rock den under my player icon.

Additional context if you help me out with how these coordinate systems work, I could fix.

architdate commented 1 year ago

So coordinate systems are based on data dumped from the game. The original file is taken from here: https://github.com/Lincoln-LM/sv-live-map/blob/master/resources/den_locations.json

The map locations are then deduced from that using the logic here: https://github.com/LegoFigure11/RaidCrawler/blob/main/MainWindow.cs#L673-L697

jnovack commented 1 year ago

It's not an issue with us, unless we don't have the newest coords list or we're parsing it improperly.

https://github.com/Lincoln-LM/sv-live-map/issues/63

Koi-3088 commented 1 year ago

Closing as "close enough" (icons not perfectly positioned, but within margin of error, and dupes have been eliminated) unless some major discrepancies are reported.