search

LegoFigure11 / RaidCrawler

Raid Viewer for Pokémon Scarlet and Violet
GNU General Public License v3.0
168 stars 59 forks source link

display day skip success rate #98

Closed pifopi closed 1 year ago

pifopi commented 1 year ago

Hello !

I added the day skip success rate for users to be able to check if their current delay settings are okay or not. I also fixed a small merge issue there was with search time

jnovack commented 1 year ago

screenshot so I don't have to download?

Without even looking, I would say put this in a "Statistics" tab in the Settings. There are a number of other things I'd like to add to a stats page too.

Additionally, the main form is getting really cluttered and some things aren't in their best spot there anyway (e.g. Game / Story Progress / Event Progress might be better served in Settings as well).

ViolentSpatula commented 1 year ago

This will be supremely helpful in dialing in timings and definitely needs to be somewhere it can be seen while the Advance Date settings are open. Possibly needs a setting to allow for it to be disabled/enabled on the main window as desired by the user.

pifopi commented 1 year ago

Indeed, it would probably be better. Should I wait for the UI to be reworked then ? ViolentSpatula explained the reason I am doing this. Here is how it looks now image Moving it would be very easy

jnovack commented 1 year ago

Should I wait for the UI to be reworked then

No, it's just the 5 of us coding, don't wait for someone else.

architdate commented 1 year ago

I'll merge this in for now, however perhaps may be prudent to look into an update to the UI to get this more streamlined and not as cluttered

pifopi commented 1 year ago

I have no idea how UI works in C#, only building my knowledge on what ViolentSpatula told me but I have no idea how to create tabs, other view, etc properly :/

architdate commented 1 year ago

No worries, thanks for the commit, could always create a separate debug control to view all this information later :)