Legomountain14 / Replantment

Adds a simple Replant enchantment to Minecraft 1.21.
MIT License
1 stars 0 forks source link

Support for Farmer Delight #1

Open Akinesis opened 1 month ago

Akinesis commented 1 month ago

Hello,

would you consider adding support for Farmer's Delight's crops ?

https://modrinth.com/mod/farmers-delight-refabricated

It would be nice to use your awsome mod on more crops than vanilla ones :)

Legomountain14 commented 1 month ago

Sorry for the late reply. I'll look into it! Shouldn't be too hard.

Legomountain14 commented 1 month ago

It's proving to be more difficult than I expected. Would you be OK with using a separate version that's not on Modrinth?

Legomountain14 commented 1 month ago

@Akinesis

Akinesis commented 1 month ago

Hello, sorry, din't saw your replies. Do as it's the more convenient for you. I've just found that farmer delight is a pretty popular and your's is a verry clean and fun way to implement the replanting gimick. If it(s not on Modrinth it's not a big deal.

Legomountain14 commented 1 month ago

I'm thinking of making another branch that has farmer's delight support and making another Modrinth page.

Akinesis commented 1 month ago

Ho yeah, a separate mod should be fine. If it's easier for you ... Farmer Delight don't seams to be easy to work with in deed.

N900GIT commented 1 month ago

I'm thinking of making another branch that has farmer's delight support and making another Modrinth page.

Would it be possible for you to create a hoe enchantment that lets you mine crops in a 3x3 area called "Harvester" It would also work with your already great mod "Replant" enchantment ideally Also would be compatible with Fortune & Telekinesis Ideally would also work with the farmers delight mod but if not I understand

"Harvester" could be a level 30 enchantment on a hoe that is considered rare like fortune III for the Pick-Axe when enchanting. You could just copy it's data for simplicity for rarity.

Here is some logic of how it may work if this helps at all

Check if Hoe in main hand --> Check if has enchantment "Harvester" --> Check if block broken has the tag "crop" --> If so break all blocks with the tag "crop in a 1 block radius surrounding the crop broken--> Check if fortune is on hoe if so All the "crops" destroyed apply fortune effect (whatever multiplier + odds is) --> Check if "Replant == true else return null" is on hoe if so replant the crop broken "seeds" or if no seed "crop" and if no crop or seed replant nothing.

You could also copy the vein mining enchantment custom enchant and see how the code applies fortune there and just copy that to the harvester enchant if that helps

I'm not a java coder I dabbled in game dev coding but this is just to help visualize I understand it's novice but hopefully it helps

I've been searching for a long time to find something like this and I haven't been able to unfortunately. Thanks, N900GIT

Legomountain14 commented 1 month ago

@N900GIT I don't know anything of java either, all I can do are datapacks. But that seems possible. I'll look into it. (My priority right now is Farmer's Delight support)

Legomountain14 commented 1 month ago

@Akinesis I think I have Farmer's delight compatibility working. Can you make sure it works? I'm attaching the datapack version. Replantment-Farmers-Delight.zip

N900GIT commented 1 month ago

@Akinesis I think I have Farmer's delight compatibility working. Can you make sure it works? I'm attaching the datapack version. Replantment-Farmers-Delight.zip

I'll test for you

update, it doesn't work assuming that its a data pack and its for 1.21 and I need to have both farmers delight mod installed anad replant datapack-farmers delight

Legomountain14 commented 4 weeks ago

@N900GIT Does it simply not work, throw an error on world start, or something else? (I'm assuming you know how to install a datapack)

N900GIT commented 4 weeks ago

@N900GIT Does it simply not work, throw an error on world start, or something else? (I'm assuming you know how to install a datapack)

The error I'm currently getting is that it doesn't show up as an enchantment currently. It's almost as if It doesn't exist. Assuming that datapack was for 1.21

Akinesis commented 4 weeks ago

I've tested it With Farmer delight and your zip file as a datapack : It work great ! Tested ok with : Cabage; Rice and Onion (so every plantable vegetable). Thank you !

Legomountain14 commented 3 weeks ago

@N900GIT Did you put the zip file in your world's "datapacks" folder?