search

LegumeFederation / cmap-js

Display and compare biological maps (genetic, physical, cytogenetic, genomic, linkage groups, chromosomes, scaffolds).
GNU General Public License v3.0
4 stars 2 forks source link

Need to find a way to completely reload the image when switching to a new map #104

Closed ekcannon closed 1 year ago

ekcannon commented 5 years ago

It may be an http(s) issue, and/or javascript issue. In either case, when the user requests a new map, the new map should be displayed. My efforts to fix this via http header directives have been unsuccessful.

This is a significant issue.

nathanweeks commented 1 year ago

@ekcannon Could you confirm if this is still an issue in the current demo cmap-js linked to from the README?

ekcannon commented 1 year ago

Loading a new map appears to be working on the demo site, but I can't confirm on PeanutBase as I can't find an instance of cmap-js on PeanutBase to check. The problem on the latter may have been due to something in the page itself. Perhaps @sdash-github knows if there is a functional copy at PeanutBase to check. That said, it would have to first be updated with the current code. Some day I'd like to implement this at MaizeGDB.

nathanweeks commented 1 year ago

Thanks for confirming. Since the issue has apparently been fixed in this repo, I'll go ahead and close the issue here.

sdash-github commented 1 year ago

Maps are not working at PB since it has been upgraded to PHP8.0.

On 3/24/23 6:42 AM, ekcannon wrote:

Loading a new map appears to be working on the demo site, but I can't confirm on PeanutBase as I can't find an instance of cmap-js on PeanutBase to check. The problem on the latter may have been due to something in the page itself. Perhaps @sdash-github https://github.com/sdash-github knows if there is a functional copy at PeanutBase to check. That said, it would have to first be updated with the current code. Some day I'd like to implement this at MaizeGDB.

— Reply to this email directly, view it on GitHub https://github.com/LegumeFederation/cmap-js/issues/104#issuecomment-1482670022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4A4644LK64PFSQYCELNQDW5WCEHANCNFSM4GQ7MN7A. You are receiving this because you were mentioned.Message ID: @.***>

adf-ncgr commented 1 year ago

@sdash-github to clarify I think the PHP8.0 issue is affecting the report pages that would typically provide links into cmap-js while cmap-js itself shouldn't have any PHP dependencies as far as I'm aware. That said, if you try to access https://peanutbase.org/cmap-js/ directly, there is an error, though I suspect it is unrelated to the PHP upgrade.