Upgrade to Mithril 2 - Githubissues

LegumeFederation / cmap-js

Display and compare biological maps (genetic, physical, cytogenetic, genomic, linkage groups, chromosomes, scaffolds).

GNU General Public License v3.0

4 stars 2 forks source link

Upgrade to Mithril 2 #125

Open Cheehau0659 opened 1 year ago

Cheehau0659 commented 1 year ago

https://mithril.js.org/changelog.html

That-Thing commented 11 months ago

The deserialize function in src/model/DataSourceModel.js returns an error which prevents cmap-js from loading further due to the data argument being null (papaparse receives a null object and throws and error).
This is somehow an issue with the 2.2.2 version of Mithril, and is most likely caused by a change in the m.request function.

That-Thing commented 11 months ago

The cfg variable in the DataSourceModel constructor being null results in the promise being rejected, which may result in no data passed to deserialize.

That-Thing commented 2 months ago

Update branch currently works fine save for a weird issue with BioMapComponent.js that stops the rendering at some point until the user clicks or drags something.

Issues fixed:

Color picker not working
Title bar component not dragging properly
The actual title not dragging with the rest of the data

That-Thing commented 2 months ago

Done.