search

LegumeFederation / cmap-js

Display and compare biological maps (genetic, physical, cytogenetic, genomic, linkage groups, chromosomes, scaffolds).
GNU General Public License v3.0
4 stars 2 forks source link

Mithril 2 update #146

Closed That-Thing closed 2 weeks ago

That-Thing commented 4 months ago

Updates mithril version to 2.

jd-campbell commented 2 months ago

@nathanweeks I am not sure if you want to review this. I think you are the most qualified within the SoyBase group to review this.

That-Thing commented 1 month ago

Tests have been ported over to Ospec, and seem to run successfully.

jd-campbell commented 1 month ago

@That-Thing User Interface error occurs when I remove a map from the Mithril 2 update version.

Old Mithril Cmap-JS after removing pv_consensus and pv_genome

Screenshot 2024-08-22 at 18 55 51

Mithril 2 Cmap-JS after removing pv_consensus and pv_genome

Screenshot 2024-08-22 at 18 55 14

I will also submit this info to the issue tracker along with any other issues I find.

That-Thing commented 1 month ago

Fixed in latest commit

That-Thing commented 1 month ago

Fixing this seemed to have caused a test to fail. Working on fixing this.

That-Thing commented 1 month ago

This seems to be behavior present in the Mithril 1.1.1 version as well. I'm going to create a separate issue for this.

jd-campbell commented 3 weeks ago

@That-Thing Lets talk about the status of this during the Cmap-JS meeting today.

maxglycine commented 3 weeks ago

@That-Thing Simon when is the meeting and could you send me a link

That-Thing commented 3 weeks ago

@maxglycine It was yesterday.

That-Thing commented 2 weeks ago

Ok everything seems to work, some tests just fail if the node version is <17 specifically in DataSourceModel.test.js because of the config import.

Are there any more issues or can I merge into main?

nathanweeks commented 2 weeks ago

Ok everything seems to work, some tests just fail if the node version is <17 specifically in DataSourceModel.test.js because of the config import.

Node < 18 is EOL & the GitHub Actions workflow tests with Node 18, so no worries regarding that.