Lehks / NostraEngine

A 3D game engine made by students of the htw saar.
MIT License
2 stars 0 forks source link

Add NOU_DLL to Plugins #78

Closed Lehks closed 6 years ago

Lehks commented 6 years ago

Currently, NOU_DLL can not be defined for Plugins. This can be fixed with the next release of NOU (1.0.1).

The code

#ifdef NOE_PLUGIN
#   ifndef NOE_PLUGIN_CLASS
//#     define NOE_PLUGIN_CLASS NOU_EXPORT_CLASS
#       define NOE_PLUGIN_CLASS NOU_CLASS
#   endif
#endif

#ifdef NOE_PLUGIN
#   ifndef NOE_PLUGIN_FUNC
//#     define NOE_PLUGIN_FUNC NOU_EXPORT_FUNC
#       define NOE_PLUGIN_FUNC NOU_FUNC
#   endif
#endif

needs to be changed to

#ifdef NOE_PLUGIN
#   ifndef NOE_PLUGIN_CLASS
#       define NOE_PLUGIN_CLASS NOU_EXPORT_CLASS
#   endif
#endif

#ifdef NOE_PLUGIN
#   ifndef NOE_PLUGIN_FUNC
#       define NOE_PLUGIN_FUNC NOU_EXPORT_FUNC
#   endif
#endif

as soon as the new NOU release is live.

This issue should be fixed when static members of classes in the engine can be accessed from within a plugin.