Lej77 / tab-unloader-for-tree-style-tab

19 stars 4 forks source link

Causes TST scrollbar to disappear #31

Closed h4-n1 closed 3 years ago

h4-n1 commented 3 years ago

With a large number of unloaded tabs, tab unloader will make the TST scrollbar disappear. This issue started yesterday for me, and until today I could still get the scrollbar back by opening a large number of empty tabs. Maybe the numbers of open tabs required to activate the scrollbar isn't counting unloaded tabs?

Tab unloader version 6.5 TST version 3.8.7 Firefox version 89.0.2 on Manjaro KDE

Lej77 commented 3 years ago

I don't think your issue is caused by this addon since it only makes minimal style changes to the TST sidebar. I suppose if you have activated some of the more experimental features such as showing hidden tabs then that could cause your problem. You can check what style changes this addon applies in the addons options page under the Custom Tree Style Tab Style header.

If you have custom style rules for TST under the advanced section of its option page then that is more likely to be the cause of your issue. It could also just be a bug of TST itself related to unloaded tabs.

h4-n1 commented 3 years ago

Thanks for responding so quickly. I tested it after clearing all TST configs (following this) and with no other TST extensions enabled - enabling tab unloader immediately caused the scrollbar to disappear. Do you think it could still be a configuration issue on my end? Or should I ask at the TST repo?

Lej77 commented 3 years ago

You could try reseting this extensions settings (there is a button for it on the options page). You could also try disabling any custom style rules that this extension applies to TST by checking that the text box in the Custom Tree Style Tab Style section is empty. This should remove all reasons that this extensions might cause you issues.

Here is the reasons I can think of for how this addons might cause your issue:

Except for those things this addon only really listens for click events on the TST sidebar and that shouldn't affect the sidebar style.

h4-n1 commented 3 years ago

I did this: 1. Disabled the addon 2. Exported TST configuration 3. Cleared TST configuration 4. Re-imported TST configuration 5. Enabled addon

And now it works. That stopped working as soon as I closed a tab. But disabling tab hiding seems to have actually fixed it.

  • You have activated this addons experimental show hidden tabs feature and TST doesn't count the shown hidden tabs.
    • This should be disabled by default (so resetting to default settings would be one way to disable it)
    • The header of the Tab Hiding section in the option page should be red (not green or yellow) when this is disabled.

I think this was it. Thanks a lot for your help.

Lej77 commented 3 years ago

I'm glad you found a solution!