search

Lej77 / tab-unloader-for-tree-style-tab

19 stars 4 forks source link

[Bug] Can't unload tree belonging to a 'group' tab #46

Open dsl101 opened 6 days ago

dsl101 commented 6 days ago

When opening tabs from, for example, a pinned tab, TST collects them together in a group with a URL like moz-extension://[TST-id]/resources/group-tab.html?title=Group... But these tabs behave differently in TST-Tab-Unloader. See the small screen recording to demonstrate. 'Normal' tabs unload the root and whole tree, whereas 'Group' tabs only unload themselves, not their descendent tree (whether by click or the context menu).

https://github.com/user-attachments/assets/65df9328-e588-4d23-9aaa-1d09333f8931

Lej77 commented 6 days ago

I tried it and your right that it isn't working. The reason seems to be that TST fails to handle the get-tree message for group tabs. We could provide a workaround for that but it would likely be better if this bug was fixed in TST itself.

Failed to get Tree Style Tab tree that should be unloaded.
Tab:  
Object { id: 9, windowId: 1, states: (2) […], indent: 0, children: (2) […], ancestorTabIds: [], bundledTabId: -1, active: false, attention: false, audible: false, … }

Error:  Error: tab.favIconUrl is null

Error location: background.js:589:41

dsl101 commented 6 days ago

I have a (maybe) related bug as other things stopped working with group tabs recently.