search

Lekensteyn / apk-downloader

APK Downloader Chrome Extension
https://lekensteyn.nl/apk-downloader/
328 stars 86 forks source link

Download button is not shown anymore #9

Closed dSeeder closed 10 years ago

dSeeder commented 10 years ago

If I am not wrong, it stopped working. No icon is showing to download. Tried signing in and out, but no luck. Is it just me or everyone?

dSeeder commented 10 years ago

using latest APK Downloader and Chrome Version 32.0.1700.107 m.

Lekensteyn commented 10 years ago

Confirmed for Chromium 32.0.1700.107, also reported by mail and on XDA. Will investigate.

dSeeder commented 10 years ago

Thanks. I hope you will find a resolution fast. Hats off for this great work.

Lekensteyn commented 10 years ago

It should be fixed now, if not, please re-open with details!

dSeeder commented 10 years ago

Thank you. It's working now. So what was the cause it was giving an error?

Lekensteyn commented 10 years ago

See b3c3eb33c38ec4c4476a0e14f7567b845aa78e05

dSeeder commented 10 years ago

So the Price was the culprit as usual. How you debugged it? I mean, how you get to know that the problem was there. Curious!

Lekensteyn commented 10 years ago

The issue was spotted by opening the Console for the background page ("Developer mode" must be turned on for the option to get visible on the Extensions page). When the page gets loaded, a message was printed to the console that the icon is not made visible.

That made clear that the breakage was not caused by Chrome API changes. Upon further inspection, it became clear that the previous condition (empty value) was not valid anymore.

dSeeder commented 10 years ago

Are you using Eclipse?

Lekensteyn commented 10 years ago

For APK Downloader, I just use vim. I use Eclipse for Android development with Java.

dSeeder commented 10 years ago

Can vim show runtime errors? What kind of apps you develop. Can I see some? :)

Lekensteyn commented 10 years ago

I use https://github.com/scrooloose/syntastic (installed via Vundle) for catching (syntax) errors and warnings in vim. My Android app development has so far only been limited to uni assignments and an unpublished app for capturing wireless traffic.

I really need to spend more time on developing Android apps, but I keep finding other projects that are more interesting ;)

dSeeder commented 10 years ago

Ha Ha. Well then send me the APK. I have a friend who will love to publish your APK on her site. :)

Lekensteyn commented 10 years ago

I can publish the APK on my site if I want, but I don't since it is not polished and required a framework and a kernel patch for proper privileges.