search

Lekensteyn / lglaf

LG Download Mode utility and documentation
https://lekensteyn.nl/lglaf/
MIT License
137 stars 74 forks source link

add challenge/response #19

Closed steadfasterX closed 6 years ago

steadfasterX commented 7 years ago

this is based on PR #12 with the following difference:

instead of adding a --unlock option to lglaf.py I use an own executable. The reason is that within download mode you need to authenticate only ONCE ( - IF you need to) and afterwards you're able to exec every other action like partitions.py etc without doing it again (until you reboot into download mode again ofc).

Lekensteyn commented 6 years ago

The review comments from the other PR still applies, e.g. python 3 compat. Maybe consider giving @snoremaster3000 credit in the header of the new script for the discoveries?

snoremaster3000 commented 6 years ago

Hey, I think I based my script on @joeblowma 's C version. I remember doing some reversing on it but I wasn't able to get the complete algorithm and he/she shared so I went ahead and just translated it (kind of poorly too, I'm not an experienced coder). So I think @joeblowma should get the credit.

Edit: Just looked through my inbox and this is definite the case, @joeblowma reversed it. Thanks,

Lekensteyn commented 6 years ago

This got taken care of in #27, if there are any issues please open a new issue.