search

Lekensteyn / lglaf

LG Download Mode utility and documentation
https://lekensteyn.nl/lglaf/
MIT License
137 stars 74 forks source link

Using cryptography lib instead of (dead) pycrypto #44

Closed tuxuser closed 6 years ago

tuxuser commented 6 years ago

Added unittest for laf crypto Made the import error more descriptive, incase laf_crypto fails to import. *Switch to cryptography lib

Lekensteyn commented 6 years ago

Changes look sane, but is this tested on Windows as well? pip install cryptography should work in theory too when using the official Python distribution right? (Maybe this is worth including in the error message?)

gjdunga commented 6 years ago

I will pull and see... I have to clean my system up. Every so often, I have to wipe it. I am way too messy...

tuxuser commented 6 years ago

Late reply: tested flawless installation of cryptography Lib on windows X86 yesterday!

Lekensteyn commented 6 years ago

Would it also be possible to update the installation instructions in the README?

tuxuser commented 6 years ago

Done ;) bonus feature: py2 compatibility :P

To run the test against laf_crypto

python -m pytest tests/
Lekensteyn commented 6 years ago

Yes, looks fine now, thanks!