search

Lekensteyn / make-gapps-zip

Documentation and tools for reproducible update.zip builds
MIT License
12 stars 9 forks source link

Update for Nougat compatibility #6

Open mfonville opened 7 years ago

mfonville commented 7 years ago

the path-expectations of oat2dex have changed, because (bak)smali has changed its interface. To find out the differences fixed in smali for N, this is a good place to start: https://github.com/JesusFreke/smali/issues/418

I will fix the style comments

Lekensteyn commented 7 years ago

When you say that the oat2dex path expectations have changed, do you mean that the included .jarfile now produces a different location? Do the comments on top of the file needs an update to reflect new paths?

mfonville commented 7 years ago

I removed the double spaces, and updated the documentation at the top a little bit, to reflect the changes that were already introduced with Marshmallow.

One big change is, that technically not all boot-stuff has to be de-odexed anymore, before the APKs/frameworks can be. But I am not 100% sure (not a real expert in this field).

Lekensteyn commented 7 years ago

I noticed that you update the oat2dex.jar twice, is there anything special with that?

Where did you get the jar from? I'll try reproduce it like I did in e55098ec07e35ccbd71daea165a972f53b9daecf

mfonville commented 7 years ago

@Lekensteyn I had it updated in an intermediate version, it ain't important but just part of my commit history...

Lekensteyn commented 7 years ago

Well, the file is 1.3MB, so if possible I would like to keep it out of the history to reduce the clone size ;-)

What commit is your jar file based on?

mfonville commented 7 years ago

Current jar is https://github.com/testwhat/SmaliEx/releases/tag/snapshot-s

Lekensteyn commented 7 years ago

Ok, would you mind if I wait a week before merging (in case the snapshot results in issues)?

mfonville commented 7 years ago

That's fine ofc; there is no hurry and the PR is mostly to at least notify you as upstream of these changes