search

Lel-Language / Lisp-esque-language

💠The Lel programming language
MIT License
27 stars 2 forks source link

Bug Fix: Inject module is not using Promise and file path is undefined in the function #38

Closed osaatcioglu closed 7 years ago

osaatcioglu commented 7 years ago

Injecting variables from module sounds like a good idea. But, I think, it might create some difficulties in maintaining scopes in the modules.

It may not obvious for the developer that a local variable or a function in a module will be visible in the called scope. I think it is better if we get the module as a function like in Javascript.

osaatcioglu commented 7 years ago

@francisrstokes I now realized that I mistakenly pull requested the wrong branch. Please ignore that one. Actually, I am pretty sure I used the correct branch but I don't know what I happened. Luckily, I checked today and saw the problem.

Sorry for the inconvenience.

francisrstokes commented 7 years ago

Hey no problem! I'm on a holiday at the moment with really limited Internet connection. I'll check in with the PRs when I get back home in a week :)