Leleat / Tiling-Assistant

An extension which adds a Windows-like snap assist to GNOME. It also expands GNOME's 2 column tiling layout.
GNU General Public License v2.0
1.15k stars 64 forks source link

Tiling apps with multiple windows does not work in conjunction with AATWS (Advanced Alt-Tab Window Switcher) #381

Open AlyMoh opened 6 days ago

AlyMoh commented 6 days ago

Describe the bug When tiling a window, e.g. to the right, the app switcher is displayed on the left side. This works as well for an app that has multiple windows, e.g. two Firefox windows.

When Tiling Assistant is used alongside AATWS, this behaviour is broken; the app switcher is displayed, but the window switcher is no longer displayed, and thus I am unable to select which window should be tiled to the left.

This is not only restricted to the left tile; it applies to any tiling.

Steps To Reproduce

  1. Open two windows of an application and one window of another application. In the screencast below, I use GNOME Web and Warp with two and one windows open, respectively.
  2. Snap the Warp window to the right.
  3. The app switcher pop-up is displayed and works, but the window switcher is not displayed underneath the Web app, even through there are two windows to choose from.

https://github.com/user-attachments/assets/81e5870a-ea65-455f-b83f-bcfce65dba03

System Info:

Journalctl logs No new entries are shown when the bug is reproduced, but the following were printed out after executing journalctl -fo cat /usr/bin/gnome-shell, probably before the bug is reproduced for the first time after boot.

fadeAndDestroy@file:///home/alymohamed/.local/share/gnome-shell/extensions/tiling-assistant@leleat-on-github/src/extension/tilingPopup.js:269:31
vfunc_key_press_event@resource:///org/gnome/shell/ui/switcherPopup.js:199:18
@resource:///org/gnome/shell/ui/init.js:21:20

If any further information is needed to help diagnose and solve this issue, please let me know! I already reported the bug on AATWS's repository.

Thank you for your time and help! :)

Leleat commented 5 days ago

Which version of AATWS are you using?

G-dH commented 5 days ago

The issue is that Tiling Assistant extends the AppSwitcherPopup class, which is already overridden by AATWS which functions differently from the default app switcher. I've only managed to handle the fatal errors caused by this conflict in AATWS.

Leleat commented 5 days ago

I am not familiar with AATWS feature set. Are there any feature in AATWS that would benefit the Tiling Popup in Tiling Assistant? If not, I can just copy GNOME's entire code for the AppSwitcher into my extension rather than try to make both extensions compatible.

Leleat commented 5 days ago

Oops, sorry, send the post to early... I am gonna edit it.

Done

G-dH commented 5 days ago

I can just copy GNOME's entire code for the AppSwitcher into my extension rather than try to make both extensions compatible.

This is the way I would choose.

The main benefit of AATWS in this use case is its support for type-ahead search for both apps and windows, as well as its ability to launch new apps. However, it’s not worth the trouble.

AlyMoh commented 5 days ago

Which version of AATWS are you using?

I am using the latest extension version from GNOME Extensions, namely version 59.