search

LemADEC / WarpDrive

A warp drive mod for minecraft
72 stars 39 forks source link

Render rings on planets #296

Open Gotyam opened 7 years ago

Gotyam commented 7 years ago

OK, so I've been deep into the config of this wanting to get Galacticraft + GalaxySpace to work together with this mod. All went well, but there is a slight issue: planets with rings. The .png for the rings cannot just be plotted into the celesitalObject render list, as then it will get stretched and look, well, weird. So I thought "why not have it has a seperate celestialObject with another size so as not to get stretched?", and so I did, but this causes the game to crash. Ofc I have set it so that overlapping objects should be allowed B:allow_overlapping_celestial_objects=true, but the crash log still tells me the crash is because of Overlapping parent areas detected in dimension -2 between Saturn and SaturnRings. If there is no other way, I will just do some texture editing to make it possible to have it all on the same, but then having the moons of planets also accessible without being far away from the planet will be difficult / impossible. If I have overlooked some part of the config files, it'd be happy to learn of it. I've only edited in celestialObjects-default.xml and config.yml

LemADEC commented 7 years ago

What version of the mod are you using? Where did you see an "B:allow_overlapping_celestial_objects" option?

Gotyam commented 7 years ago

I am using WarpDrive-1.7.10-1.3.34, and the overlapping objects config option was found in config\WarpDrive\config.yml image

Gotyam commented 7 years ago

If I have misunderstood somehting then please inform me about it. That config option was originally set to "false", and I thought turning it to "true" would make it so I could have the rings around Saturn, among others (+ the moons). If it truly isn't an option to have overlapping renders of celestialObjects, then I guess it can't be helped and I must find a way around it, but in that case I'd like for it to be an option in the future :)

LemADEC commented 7 years ago

That option was a temporary workaround for early bugs in the XML format version of the starmap. Overlapping celestial objects have unpredictable results, so the option was removed.

In your case, having a larger 'virtual' object rendering the ring will have the ring 'detach' from the planet as your approach its orbit. This will be very weird. You can add 'transparent' border around your texture then superpose a ring texture but: 1- it won't be animated 2- ship will descend on the planet while being visually above, outside the planet

Gotyam commented 7 years ago

I belive you misunderstood what I was trying to say. It might be that mentioning the rings around planets was misleading, as I would still think of having them as 2d objects, just rendered on top of the planet (and it needs different xz size values in order not to look stretched as I try to just use the textures provided through Galacticraft). The major part of the issue was when it came to the moons - so that they also can be rendered as the top layer for the planet/"above" the planet (or behind, might be a need for that as well), and not all of then needing to be (somewhat) far away. Regardless it is a low priority request, but I just want to make it more clear what it is I wish for. The ring issue could easily be fixed by tinkering with the .png from Galacticraft, making it a square instead of a rectangle.

LemADEC commented 7 years ago

I don't understand what you're trying to achieve. Make a sketch up or screenshot to explain what it is or isn't, maybe?

The game rendering engine is based on square textures. When you find rectangle textures, report it as a bug to the related author.

Gotyam commented 7 years ago

It's a bit like getting it to render like this, all in 2d as it is now, but having some parts stick out (and still have the seperate moons as something you can land on). It isn't really pretty, as I just tossed it together quickly, but hopefully it can show what I want. Saturn rendered with a moon or two behind, and also the ring rendered "above" it, along with some other moons at the top layer of the render. image Edit: Did a double-check on the ring texture, and it is indeed square, so it was just that it got compressed by the planet that made it look streched on the z axis (which led to me to believe it was a rectangular texture, despite of how minecraft works)

LemADEC commented 7 years ago

The orbiting celestial object will always be below your ship. If you have other celestial objects nearby, they'll be fairly large around you, but not around the one you're orbiting. In the case of Saturn, some moons are within the same range as of the planet's rings. Because it's a fairly large flat structure, there's no easy way to represent it in Minecraft. We could add a 'small' flat ribbon around the planet texture to get that ring feeling. Not sure if it'll really look worth it.