search

LemADEC / WarpDrive

A warp drive mod for minecraft
71 stars 40 forks source link

Items wrongly created during scanner's ship materialization #435

Closed RedShakespeare closed 4 years ago

RedShakespeare commented 4 years ago

Describe the bug When using the shipscanner to materialize a former schematic, all components in the computer case become other items. (in my own case, items appear to be those in mod GalaxySpace)

To Reproduce Steps to reproduce the behavior:

  1. Scan a former spaceship with the shipscanner.
  2. Move to another place, put a set of OC Computer(including keyboard and screen), power source(like an MFSU in mod industrial 2 exp.), a ShipController, a ShipCore and a Ship Scanner correctly according to command lines, error logs and java codes(which is not mentioned by any tutorial videos and wiki doesn't seem to help much about it...)
  3. Install OpenOS and warpdriveShipController ,reboot the computer, interrupt the controller GUI with Ctrl+C, then open lua command lines to activate the shipscanner. image
  4. Get aboard the deployed ship, check the computer case on that.
  5. See unexpected items. image image image

Expected behavior The new computer should be completely the same as the old one in both hardware and software.

Screenshots See "To Reproduce"

Versions (latest is not a valid answer)

Additional context Searched "Warp Drive mod" on youtube before raising this issue, and maybe I'm not the only one who has trouble put the wiki tutorial into practice...

RedShakespeare commented 4 years ago

By the way, really I thought there could have been pre-designed spaceship in the ship tokens until I renamed my own ship schematic as "42"... Maybe some can be added in next version? (Well, I may raise another issue about it separately...?)

LemADEC commented 4 years ago

Ship scanner doesn't need installation on the computer, it's just direct LUA methods to call. To save a ship, you just need to jump. You only need to save with a ship scanner when the ship can't jump (for example, if you build in the overworld a ship too big for a planet, etc.).

Only blocks are converted. To transfer items, you need to use the same level.dat, specifically the same mapping of item ids. So, to transfer between different world/maps, you'll have to replace the items and make a new save. That limitation is specific to 1.7.10 and older.

You can already make custom ship tokens, just rename the schematic to the token# and move it the warpdriveSchematic folder (in the root).

RedShakespeare commented 4 years ago

Thx a lot! I didn't expected to be replyed so quickly lol Besides, it took me around 1 hour making attempts and more time thinking before I finally figured out how to put things in the right place (before I raised this issue)... maybe put the reply here into wiki tutorial can help? Just a little advice =v=

(-Did I really say anything about "installing a ship scanner"?) (-And I hope more content producers (including myself if possible) can share ship tokens on the Internet for this extrordinary-designed mod (so that more design choices can be available, expect for starting designing from nothing(especially for greenhands.) ) )

LemADEC commented 4 years ago

Technically, you could use a WorldEdit schematic too, but you loose chest/block contents because that format don't support it. So, there's already lots of schematics available ;)

LemADEC commented 4 years ago

The Server FAQ section of the wiki already covers ship tokens usage, here: https://github.com/LemADEC/WarpDrive/wiki/Frequently-Asked-Questions#how-can-i-restore-a-ship-from-schematic This could use a dedicated page in the wiki.

LemADEC commented 4 years ago

Wiki is replaced with in-game documentation. The latest has a dedicated page on schematics and data fixer. Hence closing as of WarpDrive-1.12.2-1.5.14.