LemADEC / WarpDrive

A warp drive mod for minecraft
70 stars 40 forks source link

If dynamic surroundings installed, I can hear the sounds of nature. #488

Closed Exzept1on closed 3 years ago

Exzept1on commented 3 years ago

Describe the bug When Dynamic Surroundings is installed and when I go to space, I hear the sounds of the biome.

To Reproduce Steps to reproduce the behavior:

  1. Install WarpDrive
  2. Install Dynamic Surroundings
  3. Jump to Space
  4. Hear biome sounds(water breeze or birds songs)

Expected behavior I can hear the sounds of nature, even though I'm in space.

Screenshots [Biome river in space XD] 2021-04-20_19 35 56

Logs Not needed

Versions (latest is not a valid answer)

Additional context Not needed

Exzept1on commented 3 years ago

Since Dynamic Surroundings reproduces its sounds in certain biomes, I would suggest making a biome with the name space in the dimension of the space(and hyperspace). Because now I saw that even when I'm in space, the biome doesn't change. For example, I was in Plains, teleported into space, and still the biome remained Plains.

LemADEC commented 3 years ago

The space dimension is exclusively made with the space biome already by design. If you still hear sounds, there's probably another mod messing around with biomes like notably NotEnoughIds. There was also discussion with having per dimensions settings in Dynamic Surroundings to account for that, notably to remove the altimetric fog back in the days. Either way, it's not a WarpDrive issue :).

Exzept1on commented 3 years ago

Its JustEnoughIds issue, oh sorry then.