Lembas-Modding-Team / pvp-mode

A Minecraft mod offering various options to manage availability for and ability to PvP.
GNU Lesser General Public License v3.0
5 stars 3 forks source link

Improved player radar #14

Open CraftedMods opened 6 years ago

CraftedMods commented 6 years ago

As PvpMode is intended to be a server-side mod, we don't have many options to represent the player radar. One solution could be to create an optional client-side mod, which could represent the radar in a nice way (but this is overhead for us and the servers). Another option would be to use what MC already provides - to example the scoreboard. What I suggest is to add scoreboard support (configurable of course) for the player radar. The distance to other players with pvp activated for one player then would be displayed in a sidebar (example: https://minecraft.gamepedia.com/File:Scoreboard.png), with a configurable refresh rate and so on. Server owners could deactivate this feature, and players would have to choice to enable/disable the radar display (via a new command pvpradar). So, what do you think?
This could be combined with this planned feature:

Configurable refresh rate and unit of measure for the distance shown in the player radar function.
Units of measure are to be determined.

@AlteOgre could you explain this planned feature in a more detailed way? I'm unsure whether I understood this correctly.

AlteOgre commented 6 years ago

Good thinking again. Additional client side mods are a no-go. Most of the community is used to servers requiring only the LOTRmod to play.

I think a proximity info list of closest-by players in pvp mode that would be more easily accessible/visible to players in pvp mode will be beneficial to both the players, the servers they play on, and the mod. Your proposal seems adequate to provide in this need: utilise the build-in scoreboard functionality many of us all know from plugins like MCMMO, Races&Classes, SkillAPI and whatnot. So, if you feel like adding that, with the customisability aspects you mention, do go ahead. But I think it is less urgent than the v1.0 release, leaning on the pvp logging feature we promised the current users and the server owners awaiting this feature before implementating the mod on their server. As far as functionality goes: 1) I would prefer the scoreboard function to be independent of the info shown with /pvplist. That list should provide an overview to anyone hailing it. 2) ~The closest player with pvp mode on, and proximity radar on, should be shown topping the list.~ (Outsourced to #63) 3) A refresh rate, in seconds, could be made a server config setting. 4) players should be able to determine whether or not they use proximity radar (implying they can see others, and others can see them), and if the scoreboard is shown, and how many closest players are shown (provided the number of players in pvp mode with proximity info enabled is longer than the specified number). The list length could be limited to a fixed value of 10 or so? Commands must be simple and straightforward, like /pvp proxinfo on/off, /pvp proxlist on/of and /pvp proxlist 5. 5) ~The current default for the rounding of proximity data can best be set to 100 instead of 64. (As a side-note.)~ (Implemented)

I hope this will do. The feature isn't actually planned, but already implemented. The proposal you bring forward is an improvement of the existing feature in my view.

Final notes: The meaningfulness of the feature depends on the server use of 'Show Map Location' by players. Some force that ON. In that case, the proximity info doesn't add much to the player and server owners will disable the feature in the config ... unless the scoreboard would be implemented the way you propose. We assume players are free to choose whether they show their map location, and I personally recommend to generally leave it OFF for the sake of roleplay immersion (reduced metagaming), except for special events. The reasoning behind the proximity radar is presented in the functional description for the mod, v3.

CraftedMods commented 6 years ago

I've finished the combat logging a few hours ago, a test version for you can be found at the issue (#7 ). I'm just waiting for your feedback.

CraftedMods commented 6 years ago

This is definetely something for the next versions. If @VulcanForge adds me as collaborator, I'll create milestones for future versions so that we can organize our issues and see which feature is planned for which version. I've played a bit around with the scoreboard: Adding this is more complicated than it seems and isn't what the scoreboard is intended to be used, but it's definetely possible, even if it feels wrong. We only have to integrate it in a way that is compatible with servers that use the scoreboard for other features (which means that this has to be disableable). The best solution indeed would be a client side mod, but as @AlteOgre already said, this contradicts the idea of a server-side only mod.

CraftedMods commented 6 years ago

Another option would be that a client-side mod would be optional. So players who installed it would have a GUI which displays the radar in a nice way. This could be configured by the server owners. Of course the scoreboard support still would be a think - but it isn't as compatible as a custom HUD.

AlteOgre commented 6 years ago

Aye. Nice to have. Lower prio than the planned conditional overrides afaic.

CraftedMods commented 6 years ago

Sure.