LemmaLegalConsulting / docassemble-MOHUDEvictionProject

DIY Form tools for MOTenantHelp including Eviction Defense Document Engine (EDDE)
https://motenanthelp.org
MIT License
2 stars 0 forks source link

consolidate buttons on review screen #492

Closed tobyfey closed 7 months ago

tobyfey commented 9 months ago

Updating review screen

In this PR, I have:

tobyfey commented 8 months ago

I didn't add any conditional logic inside ${ }, I added backslashes at the end of the text to fix the problem.

miabonardi commented 8 months ago

Ok! That helps then. I still dont think this is exactly what @nonprofittechy was asking.

miabonardi commented 8 months ago

From @tobyfey

I saw in Pfeiffer a review block that seems to be like Quinten is talking about. I don't know if that will work with the factors that are asked in different spots (which we were using edit above before).

Toby-- what do you mean by "the factors that are asked in different spots"?

miabonardi commented 8 months ago
nonprofittechy commented 8 months ago

Maybe a clearer information hierarchy that uses heading level 2, 3, and 4 with a little longer text like this:

image

miabonardi commented 8 months ago

I tested this on mobile. While we wait on accordion-type edit screens, what are your thoughts on putting an additional "Continue" type button at the top of the review page screen (in addition to having one at the bottom)?

miabonardi commented 7 months ago

See #376

miabonardi commented 7 months ago

Updated and ready for a new review, Mia and Toby testing on mobile, Toby testing again for 4.

@nonprofittechy can you check this out:

  1. There is something buggy going on with the footer. I was in a Chrome browser on Mac and captured it in two screenshots, but note I scrolled to the side to grab it. It is only on the review screen / screen with accordion that this happens.

Screen Shot 2024-02-21 at 7 36 42 AM Screen Shot 2024-02-21 at 7 36 59 AM

tobyfey commented 7 months ago

I don't see the footer issue on Android.

miabonardi commented 7 months ago

What browser do you use on desktop?

nonprofittechy commented 7 months ago

I can't look closely, but is it possible that there's an unclosed div or other html element that is swallowing part of the footer?

Make sure all the open/closing html tags match up.

tobyfey commented 7 months ago

I can't figure out how to recreate the problem with the footer.

tobyfey commented 7 months ago

I tried Chrome and Firefox and the responsive design mode on each.