This commit fixes many issues, especially with the review block and adding the motions to the block
We moved the service block before the review screen, which allows us to put the address in the review screen and helped us avoid adding features to reuse addresses for the service address.
We added statements calling .enabled for motions we added to EDDE, sometimes with an order to collect the needed facts
For stats tracking, we added showifdef for the variables that track time, unless it is the most recent time that should be called when the stats are collected. We also added the case number Terry requested
We added follow up questions about final_judgment and trial_date to determine whether to do a motion to set aside instead of an answer, and soft exit (id: soft exit old judgment below) if the judgment is over a year old.
We created a variable any_defense_true to make the Affirmative Defense title only appear if there was a defense.
We deleted explanation answer, since explanations are on the review screen and evidence tips could be on the discovery screen
We brought the motion to shorten time order over from the file_a_motion.yml and made some changes - we got rid of trial_date because now the motion is conditoned on trial_date_set so that question will be asked before
We conditioned other documents on the motion to set aside not being enabled, because if a motion to set aside is used, then the notice of hearing and instructions are the only other documents that should be attached
We changed the logic for the motion to shorten time in a way that we thought was more appropriate. The document is for when the trial date is too soon to give the other side the full time to respond to discovery. So it should be enabled when a trial date is set, not when the original hearing date is still in the future.
We added the new motions to the list gathering motions to use in the notice of hearing.
We got rid of reminders and the question about using casenet in the motion to continue like we did for EDDE.
We added a question about original_hearing_date just for the motion to continue in order to use min: today to validate the input.
We embedded videos with explanation.
We tried to replace case_type with eviction_reason questions because eviction_reason is required and more specific, and the no breach defense can be limited to lease violation cases.
We added needed depends on, because failure to terminate depends on eviction reason and is rent subsidized
We moved the specific reminders about evidence to the page with discovery to make it a Proving Your Case page. DELETE EXPLANATION ANSWER
In File a Motion, we added users attorney in the order like in EDDE because the signature block wasn't being completed.
We moved most of the questions used by the motions to shared. yml and moved a few back, like the questions for trial_date_set and trial_date.
We got rid of motions_attached which wasn't being used.
We simplified the users attorney block in both file a motion and EDDE.
We added more recomputes when the address changes, because rent pleading defense and notice of sale defenses are different based on county
Added review fields for new and missing facts, and tried to make the defenses not included explanations a little more understandable when it was confusing or wrong.
fix #640
fix #639
fix #538
fix #615
fix #402
fix #446
fix #593
fix #543
fix #462
fix #623
### In this PR, I have:
* [x] Manually tested to ensure my PR is working
* [x] Ensured issues that this PR closes will be [automatically closed](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
* [x] Requested review from Mia or Quinten
* [ ] Ensured automated tests are passing
* [ ] Updated automated tests so they are now passing
* [ ] There were no automated tests on this repo so I filled out [this interview](https://apps-dev.suffolklitlab.org/run/test-setup/) and there is now an "it runs" test
)
This commit fixes many issues, especially with the review block and adding the motions to the block
We moved the service block before the review screen, which allows us to put the address in the review screen and helped us avoid adding features to reuse addresses for the service address.
We added statements calling .enabled for motions we added to EDDE, sometimes with an order to collect the needed facts
For stats tracking, we added showifdef for the variables that track time, unless it is the most recent time that should be called when the stats are collected. We also added the case number Terry requested
We added follow up questions about final_judgment and trial_date to determine whether to do a motion to set aside instead of an answer, and soft exit (id: soft exit old judgment below) if the judgment is over a year old.
We created a variable any_defense_true to make the Affirmative Defense title only appear if there was a defense.
We deleted explanation answer, since explanations are on the review screen and evidence tips could be on the discovery screen
We brought the motion to shorten time order over from the file_a_motion.yml and made some changes - we got rid of trial_date because now the motion is conditoned on trial_date_set so that question will be asked before
We conditioned other documents on the motion to set aside not being enabled, because if a motion to set aside is used, then the notice of hearing and instructions are the only other documents that should be attached
We changed the logic for the motion to shorten time in a way that we thought was more appropriate. The document is for when the trial date is too soon to give the other side the full time to respond to discovery. So it should be enabled when a trial date is set, not when the original hearing date is still in the future.
We added the new motions to the list gathering motions to use in the notice of hearing.
We got rid of reminders and the question about using casenet in the motion to continue like we did for EDDE.
We added a question about original_hearing_date just for the motion to continue in order to use min: today to validate the input.
We embedded videos with explanation.
We tried to replace case_type with eviction_reason questions because eviction_reason is required and more specific, and the no breach defense can be limited to lease violation cases.
We added needed depends on, because failure to terminate depends on eviction reason and is rent subsidized
We moved the specific reminders about evidence to the page with discovery to make it a Proving Your Case page. DELETE EXPLANATION ANSWER
In File a Motion, we added users attorney in the order like in EDDE because the signature block wasn't being completed.
We moved most of the questions used by the motions to shared. yml and moved a few back, like the questions for trial_date_set and trial_date.
We got rid of motions_attached which wasn't being used.
We simplified the users attorney block in both file a motion and EDDE.
We added more recomputes when the address changes, because rent pleading defense and notice of sale defenses are different based on county
Added review fields for new and missing facts, and tried to make the defenses not included explanations a little more understandable when it was confusing or wrong.