Lemmons / pytest-raises

An implementation of pytest.raises as a pytest.mark fixture

MIT License

19 stars 8 forks source link

register raises/setup_raises as custom markers #18

Closed svenevs closed 5 years ago

svenevs commented 5 years ago

Prevents PytestUnknownMarkWarning in consuming packages.

Currently:

/tmp/tox/exhale/py/lib/python3.7/site-packages/_pytest/mark/structures.py:324
  /tmp/tox/exhale/py/lib/python3.7/site-packages/_pytest/mark/structures.py:324: PytestUnknownMarkWarning: Unknown pytest.mark.setup_raises - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html
    PytestUnknownMarkWarning,

If I install git+https://github.com/svenevs/pytest-raises.git@fix/register-markers-with-pytest right now the warning will go away :slightly_smiling_face:

As noted, this never shows up in the tests locally. I don't really know how to achieve that. I also didn't add arguments (see here), because the supported arguments for this package are variable and I think that makes things more confusing than it is worth.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files           2        2           
  Lines         101      101           
=======================================
  Hits           99       99           
  Misses          2        2

Impacted Files	Coverage Δ
pytest_raises/pytest_raises.py	`96.82% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b80a1dc...1cce3a0. Read the comment docs.

Lemmons commented 5 years ago

Thanks for all the work on this @svenevs. Would you be interested in being a maintainer for this project? As it stands I don't have time to put much into it, so it would definitely help keep things current.

svenevs commented 5 years ago

No problem. And sure, happy to help maintain. This project doesn't need much upkeep, mostly just adapting to changes in pytest. I think it's basically feature complete :)

If you want to chat offline about logistics / merge / review protocol etc, my email is [my_github_username].dev@gmail.com