search

Lemmons / pytest-raises

An implementation of pytest.raises as a pytest.mark fixture
MIT License
19 stars 8 forks source link

Compatibility issue with pluggy 1.4 #32

Open Midnighter opened 1 month ago

Midnighter commented 1 month ago

pytest-raises has been my trusted companion for many years now. Since pluggy 1.4, however, old-style hook wrappers cause test failures.

pluggy.PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.

There is a discussion at https://github.com/pytest-dev/pytest/discussions/11858, for example, that mentions potential approaches.

AetherUnbound commented 2 weeks ago

@svenevs @Lemmons I'm seeing this as well - I can take a stab at it to try and find a solution, but I wanted to check in. Are you two around for possibly deploying a new version as well? There's some maintenance that might be beneficial for the project (since the last release was in 2020). Happy to pitch in on that if you'd like 🙂

svenevs commented 2 weeks ago

Hey team, I'm happy to try and look into this on Sunday. Generally this plugin is intended to be feature complete / low maintenance, but it does appear it's time for a facelift.

I haven't had time to dig into what's going on, but from a brief skim of the linked issue it does seem like we've got a viable path forward. @AetherUnbound if you have time to get a prototype working I can definitely review and make sure the packaging requirements are updated etc.

Thank you @Midnighter for the detailed report and link to the discussion!