LemmusLemmus / GlosSI-Integration-Playnite

A Playnite extension that automates creating, launching and closing of GlosSI Steam shortcuts for your games.
GNU General Public License v3.0
28 stars 0 forks source link

Shortcut doesn't fill the Path and Launch Arguments #24

Closed tymondouglas closed 4 months ago

tymondouglas commented 1 year ago

Self-explanatory, but every time i add a new shortcut through PlayNite / GlosSI-Integration, it creates an empty target in Glossi, resulting in it only launching Glossi-target instead of launching the game. Picture related: Shortcut created through integration image

Target JSON:

{
    "controller": {
        "allowDesktopConfig": false,
        "emulateDS4": false,
        "maxControllers": 4
    },
    "devices": {
        "hideDevices": true,
        "realDeviceIds": false
    },
    "extendedLogging": false,
    "icon": "C:\\Users\\Tymon\\AppData\\Roaming\\Playnite\\library\\files\\e6964537-8e74-4d13-8b82-bc4bf4fb2b0a\\4d756d57-babe-4516-9f96-0e6f00b4c489.png",
    "launch": {
        "closeOnExit": false,
        "ignoreLauncher": true,
        "killLauncher": false,
        "launch": false,
        "launchAppArgs": null,
        "launchPath": null,
        "launcherProcesses": [
        ],
        "waitForChildProcs": false
    },
    "name": "Rune Factory 4 Special - Windows Edition",
    "oldName": "Rune Factory 4 Special - Windows Edition",
    "snapshotNotify": false,
    "version": 1,
    "window": {
        "disableOverlay": false,
        "maxFps": null,
        "scale": null,
        "windowMode": false
    }
}
LemmusLemmus commented 1 year ago

This is currently the intended behavior. When you launch games via Playnite, Playnite will launch the game itself and the GlosSITarget shortcut will be launched as merely an overlay. As such, the game paths of the created shortcuts are empty, since Playnite does the game launching and one would not want to launch the same game twice.

It is not optimal however, since the shortcut becomes practically useless when launched from Steam. This should hopefully be resolved in the next version of the extension, by (among other things) automatically disabling and enabling game launching from GlosSITarget based on whether it was launched from Steam or the Playnite extension.

tymondouglas commented 1 year ago

I see, thanks. I should have specified that it only happened when launching through steam.

LemmusLemmus commented 1 year ago

If you are interested in trying out an experimental version that adds this functionality, see https://github.com/LemmusLemmus/GlosSI-Integration-Playnite/issues/23#issuecomment-1704314198.