LemmyNet / activitypub-federation-rust

High-level Rust library for the Activitypub protocol
GNU Affero General Public License v3.0
409 stars 46 forks source link

chore: update .gitignore #115

Closed kwaa closed 2 months ago

kwaa commented 2 months ago

Set up a minimal devShell. (flake + nix-direnv)

This applies to everyone who uses the nix package manager and facilitates my next (possible) contribution. (https://github.com/importantimport/hatsu/issues/50)

Update .gitignore to ignore nix flake files.

kwaa commented 2 months ago

cc @Nutomic

I'm unsure what the CI failed for.

Nutomic commented 2 months ago

I dont use nix so I wouldnt be able to maintain this. Anyway its a completely standard Rust project, why would you need some special config as part of the repo?

kwaa commented 2 months ago

I dont use nix so I wouldnt be able to maintain this. Anyway its a completely standard Rust project, why would you need some special config as part of the repo?

I'm using NixOS and need devShell to get the rust-analyzer to work properly on VSCode. (https://github.com/LemmyNet/activitypub-federation-rust/pull/115/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0R31)

It's a simple stable toolchain that doesn't require much maintenance.

Alternatively, it might be possible to add flake.{nix,lock} and .envrc to .gitignores so that I can open PR without committing those files.

Nutomic commented 2 months ago

Yes I prefer adjusting gitignore.

kwaa commented 2 months ago

Yes I prefer adjusting gitignore.

Okay, I've updated PR.

Nutomic commented 2 months ago

Thanks, but please put some comments what these gitignore lines are for. The CI failure is not yours, a test is trying to connect to a broken server. Gonna fix it soon.

kwaa commented 2 months ago

Thanks, but please put some comments what these gitignore lines are for.

done

Nutomic commented 2 months ago

Thanks!