search

LemmyNet / activitypub-federation-rust

High-level Rust library for the Activitypub protocol
GNU Affero General Public License v3.0
409 stars 46 forks source link

refactor!: use `rsa` instead of `openssl` #116

Closed kwaa closed 2 months ago

kwaa commented 2 months ago

closed https://github.com/LemmyNet/activitypub-federation-rust/issues/49

cc @Nutomic

This PR uses rsa crate instead of openssl to make the project more portable.

The private_key here looks isn't in pkcs8 format, so I've used from_pkcs1_pem here.

Nutomic commented 2 months ago

Very nice! To fix the test failure you need to merge commits from main branch to yours.

kwaa commented 2 months ago

To fix the test failure you need to merge commits from main branch to yours.

The master branch doesn't seem to have any new commits. https://github.com/LemmyNet/activitypub-federation-rust/commits/main/

Nutomic commented 2 months ago

My bad, I didnt commit/push my change :facepalm:

https://github.com/LemmyNet/activitypub-federation-rust/pull/117

kwaa commented 2 months ago

Ive confirmed that Lemmy federation tests are passing with these changes. So you just need to pull in the test fix in order to merge.

I updated the branch.

dessalines commented 2 months ago

This should also probably be done for lemmy too. I'll open an issue.