search

LemmyNet / jerboa

A native android app for Lemmy
GNU Affero General Public License v3.0
1.16k stars 166 forks source link

Tries to display videos in markdown comments #1188

Open MV-GH opened 1 year ago

MV-GH commented 1 year ago

Jerboa Version

0.0.44

Android Version + Phone

n/a

Describe The Bug

The coil images plugin for markwon tries to display videos. It should just leave the link as is.

https://github.com/dessalines/jerboa/assets/67873169/3ec013fb-0699-482e-b12d-5e289d391073

To Reproduce

find a comment with mp4 link in comments, watch it display error placeholder as it can not display videos.

In the case of a crash or when relevant include the logs

No response

MV-GH commented 1 year ago

when doing ![](vidlink) it tries to turn into a drawable or something that CoilImage would try to display

MV-GH commented 7 months ago

Current behaviour is that it should show the first frame of a video, I am guessing that the end goal that it would open up the video player?

dessalines commented 6 months ago

Yes, I'd much prefer it just try to do use whatever program android wants for that video uri.