Instead of showing Score, Upvote, and Downvote, show only Score and Upvote Percentage (or sentiment icon)

LemmyNet / jerboa

A native android app for Lemmy

GNU Affero General Public License v3.0

1.16k stars 166 forks source link

Instead of showing Score, Upvote, and Downvote, show only Score and Upvote Percentage (or sentiment icon) #1372

Open dessalines opened 7 months ago

dessalines commented 7 months ago

Pre-Flight checklist

[X] Did you check to see if this issue already exists?
[X] This is a single feature request. (Do not put multiple feature requests in one issue)
[X] This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

@MV-GH I'd like your feedback before I start working on this.

Currently, on every post / comment, we show 3 pieces of info:

A score in the header bar
Upvote and downvote count in the footer / action bar.

Sample:

Screenshot_2024-02-12-12-52-32-271-edit_com jerboa_1

This is kind of a lot of mostly redundant info.

It'd be nice to simplify this (like some other apps I've seen), and show only

A score and an upvote percentage in the header bar.
- We could also hide the upvote percentage if its above a certain threshold (IE 80% liked)
- And instead of a percentage number, we could show one of these sentiment icons

This would move the pieces of info shown from 3 down to 2 (or 1 if its a well liked item).

MV-GH commented 7 months ago

I am open for this, but I would lean on making this a setting at first. Also I prefer percentage (Hide this if its 95%+)

dessalines commented 7 months ago

Sounds good, I think I prefer the percentage also.

dessalines commented 7 months ago

I've decided that this is a pervasive enough setting that it should probably live in the back-end.

I can implement this before we add that back-end setting referenced above, by using a dummy setting.

MV-GH commented 7 months ago

We are gonna need something dummy regardless for backwards compatibility :/

Lemmy.world is not even on 0.19 yet so the backwards compatibility is still pretty important.

or for Lemmy version which don't implement that feature yet, we can just assume they want the old behaviour and only make the setting available for instances that support the feature

dessalines commented 7 months ago

For sure, mainly I just want to hold off on adding a DB migration in jerboa, and instead make this a back-end user setting.

EDIT: errr scratch that. It might be a while till we deploy that new feature anyway. So maybe I will add an app-specific setting, then eventually disregard it.

MV-GH commented 7 months ago

Isn't this then a setting on Acccount too? like listing etc

dessalines commented 7 months ago

Yep, I imagine it would be good to persist there also, just like default_post_listing_type, etc. But the true source value will be from the back-end.

We should also do this for the new PostListingMode setting, and move that one out of the app settings.

MV-GH commented 7 months ago

Ah that was added for 0.19. For 0.18 we use account, as source of truth then