search

LemmyNet / jerboa

A native android app for Lemmy
GNU Affero General Public License v3.0
1.14k stars 167 forks source link

Set specific versions for runtime-livedata. #1502

Closed dessalines closed 1 month ago

MV-GH commented 1 month ago

Why was this done? I had to remove them had this issue https://stackoverflow.com/questions/78360992/java-lang-illegalstateexception-compositionlocal-locallifecycleowner-not-presen

dessalines commented 1 month ago

Whoops. android studio complained about these. I'll revert this then.

MV-GH commented 1 month ago

Actually even with that change I am still experiencing it in different parts of the app. Opening the imageviewer will result in crash

java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present

We can't release until we fix this.

Edit found out why https://issuetracker.google.com/issues/336842920

Lifecycle 2.8 requires compose 1.7 But compose 1.7 is still in alpha so there is no Compose BOM release yet

So we either wait for that or we use this as interim https://github.com/chrisbanes/compose-bom

dessalines commented 1 month ago

Seems like using https://github.com/chrisbanes/compose-bom is the best short-term fix, so we don't have to make any code changes.