search

LemmyNet / jerboa

A native android app for Lemmy
GNU Affero General Public License v3.0
1.14k stars 166 forks source link

Add blocks screen #1545

Closed MV-GH closed 2 weeks ago

MV-GH commented 3 weeks ago

Thanks @rodrigo-fm , I have largely based this PR from yours.

https://github.com/LemmyNet/jerboa/assets/67873169/60934659-8541-40ef-b22c-a6773db1a293

rodrigo-fm commented 3 weeks ago

I ran the app and blocked one community and one user. Then I navigated to the BlocksActivity, but I couldn't see the user and the community I blocked, I had to drag the screen to trigger the reload, only then the screen showed the user and the community I blocked.

I think you can run the update event when the user opens the BlocksActivity to avoid the need to drag the screen to update. Other solution is to update the blocked users/community/instance lists when a block occurs. I think I used the first solution when I worked on this.

rodrigo-fm commented 3 weeks ago

Btw thank you very much for continuing the blocks screen work! :)

MV-GH commented 3 weeks ago

I didn't want to do that initially because it would make it load first each time they open the screen. But I guess this a common usecase

Edit: I have made it so that you can see the current state and in the meantime it loads a newer state. So that you don't see a empty loading screen.