LemmyNet / lemmy-ui

The official web app for lemmy.
https://join-lemmy.org/
GNU Affero General Public License v3.0
892 stars 334 forks source link

Bad autocomplete for !community@instance #2803

Open Die4Ever opened 4 days ago

Die4Ever commented 4 days ago

Requirements

Summary

Typing !fedigrow@lemm.ee gives the autocomplete for !fedigrow[!fedigrow@lemm.ee](https://lemm.ee/c/fedigrow), which is unnecessary since all frontends correctly handle the plain !fedigrow@lemm.ee (I think even Mbin handles this correctly)

And the autocomplete incorrectly takes you to a remote instance. Also the autocomplete incorrectly shows the community name twice

Screenshot_20241109-160005 shows the community name twice.

Steps to Reproduce

  1. Type !fedigrow@lemm.ee
  2. Click autocomplete
  3. See incorrect markdown
  4. Click Preview and see incorrect result

Technical Details

Tested in Chrome and Firefox

Discussion here: https://lemmy.world/post/21832647

Lemmy Instance Version

0.19.5

Lemmy Instance URL

programming.dev

DraconicNEO commented 4 days ago

We really just need to stop having it autocorrect to a URL embed via []() and allow people to just type !community@instance.tld and autocorrect to the community without embedding the link as a link format. Especially since the backend already handles annotating the community links already without needing to do that and makes them functional on any instance, but directly linking hardcodes them to that instance which is a poor choice for remote users who will just get redirected there instead of the community on their own instance.