Open ahangarha opened 3 years ago
Thanks! Again I personally don't have time to work on this, but hopefully that code can be helpful to someone who does.
No update made to this? we need the RTL from lemmy`s master branch very much so we can get the updates.
If you want this to be implemented, you can work on it yourself (or hire someone to work on it), and then make a pull request. We would definitely like to merge this functionality.
No progress made on this @dessalines @Nutomic ?
No. Read the comments above.
I couldn't find anyone to make it this is why i'm asking.
Hey @jayabie Feel free to say hi at @mjxtb:matrix.org - we can team up on this.
@xximj Thanks for your invitation, i will join soon.
Hi guys, we had a draft PR that was supposed to work on other sections last week. is it in progress, I also want to contribute to this case
Hi guys, we had a draft PR that was supposed to work on other sections last week. is it in progress, I also want to contribute to this case
Hey, do you mean #1963 or something else you were working on? Anyways, we love to see progress on this part, especially on comments section.
Last week i have done some testing with comments section and it's kinda impossible to make HTML ul
s bidirectional. only one direction can be chosen.(maybe i wasn't trying hard).
@dessalines When can we expect the new UI to be ready? Is it worth it to make effort and fix this UI?
For lists, only we can add direction to ul
and not to li
. Don't waste time on fixing issues with li
.
For lists, only we can add direction to
ul
and not toli
. Don't waste time on fixing issues withli
.
Yup, i've tested it, and if we can make it happen, it's gonna look ugly.
For comments section, we should avoid using ul
.
May you share some screenshots of what you see as ugly?
May you share some screenshots of what you see as ugly?
I couldn't make it happen, it was hypothetically. one comment on left and another on right, inside chain of replies, should be hard to follow.
That is the nature of the issue. It happens the same if we do it here. See:
این متن فارسی است و در به صورت یک متن RTL با تراز راستچین نمایش داده میشود.
Any updates on this? @ahangarha did you get to work on comments section? At least we can merge the parts that is working(#1963)
I haven't worked on it yet.
Since the current partial solution doesn't harm the project, I would say we can ask for merging #1963
For lists, I need to make a new release in markdown-it-bidi
. But I don't think this is a crucial issue for now.
Let's have this issue open as it it not totally completed, but partially. The comments section needs BIDI too.
@hamidrezakp Can you make a checklist of what is done and what are remaining?
@hamidrezakp Can you make a checklist of what is done and what are remaining?
Sure:
Although we should discuss if we want to have post title be bidi even if users layout is different than title direction (e.g. User with en_us
language opens a Persian post with Persian title).
Other than post title, imo we just need comments to be bidi for now.
And please update your first comment and mention current status.
if we want to have post title be bidi even if users layout is different than title direction We should have bidi by I think what you mean is that if we should enforce text alignment with
left|right
rather thanstart
.
This is important but it is a design decision.
I just submitted a backend PR which allows Arabic (and Cyrillic) in usernames and community names: https://github.com/LemmyNet/lemmy/pull/4083
Is your proposal related to a problem?
Considering the very nature of social media platforms (like Lemmy), people with different languages would create content. It becomes problematic when one creates content in RTL languages (like Persian, Arabic, Urdu,...). Lemmy is not ready to render RTL (or even mixed RTL/LTR) text properly.
Describe the solution you'd like
There are two approaches in general. One is through HTML modification which can be done by add
dir="auto"
attribute to elements containing user generated text or by wrapping it in<bdi>
tags. The other approach would be through CSS by addingunicode-bidi: plaintext
. In either of approaches, there should be avoidance in using absolute positioning or spacing. For example instead oftext-align: left
we should usetext-align: start
or instead ofpadding-left
we should usepadding-inline-start
unless there be some strong UX reason.Describe alternatives you've considered
--
Additional context
Just keep in mind that bidi (bidirectional text) is different from using RTL or LTR in general based on the language user choose for the interface.
I have opened this issue here not on back-end because I think this can be managed on front-end.
Todo