search

LemmyNet / lemmy-ui

The official web app for lemmy.
https://join-lemmy.org/
GNU Affero General Public License v3.0
879 stars 334 forks source link

Markdown not formatting in news feed #673

Open Kap2022 opened 2 years ago

Kap2022 commented 2 years ago

When you include markdown in your post e.g. a link or italics or bold - it formats perfectly in the post.

But it does not format in the newsfeed and that can look very ugly and unprofessional, especially if it is a link, etc.

dessalines commented 2 years ago

Could you show an example? If you mean the front page short summary no longer rendering markdown, that's correct.

Nutomic commented 2 years ago

Was changed here: https://github.com/LemmyNet/lemmy-ui/pull/659

I think it was mainly because it allowed for video to be played on the main page from a post body (https://github.com/LemmyNet/lemmy-ui/issues/650). But that has been fixed by disabling html parsing, so maybe markdown could be enabled again for previews, as the unformatted one looks pretty ugly. Some things like titles should be disabled for the preview though).

dessalines commented 2 years ago

It looks like its possible to disable certain rules. So IMO this doable. That also might not be necessary if we use md.renderInline

Kap2022 commented 2 years ago

Screenshot_20220602-224055 This first one should be bullets where the dashes are

Kap2022 commented 2 years ago

Screenshot_20220602-224903 Example of bold

Kap2022 commented 2 years ago

Screenshot_20220602-225050 Example of a link

Kap2022 commented 2 years ago

Screenshot_20220602-225201 Example of italics

alectrocute commented 1 year ago

This looks like it can be safely closed, doesn't seem applicable to 0.18 at least.

snaggen commented 1 year ago

from feed https://programming.dev/c/rust (programming.dev runs 0.18.0) bild

If I click the post it renders correctly bild

So, it seems this is still an issue, unless I missunderstand what this issue is about.