LemmyNet / lemmy

🐀 A link aggregator and forum for the fediverse
https://join-lemmy.org
GNU Affero General Public License v3.0
13.26k stars 882 forks source link

Weird production bug on enterprise.lemmy.ml #2673

Closed dessalines closed 1 year ago

dessalines commented 1 year ago

All my API requests will return errors, even though they actually go through. If I restart enterprise.lemmy.ml , it works, but only for a little while.

This could be a release-blocking bug.

bug

lemmy_1     | 2023-01-26T17:09:29.150965Z  WARN Error encountered while processing the incoming HTTP request:
 lemmy_server::root_span_builder: Session is closed                                                                                              
lemmy_1     |    0: 
lemmy_api_common::websocket::send::send_comment_ws_message                                                 
lemmy_1     |              at crates/api_common/src/websocket/send.rs:58                                                       
lemmy_1     |    1: lemmy_api_crud::comment::create::perform                                                                   
lemmy_1     |            with self=CreateComment { content: "Mmmk", post_id: PostId(388517), parent_id: None, language_id: None, form_id: None, auth: Sensitive }                 
lemmy_1     |              at crates/api_crud/src/comment/create.rs:41                                                         
lemmy_1     |    2: lemmy_server::root_span_builder::HTTP request
dessalines commented 1 year ago

@Nutomic I think we'll have to delay the release, you made a lot of changes to the chat_server.rs, in how it sends messages, and it broke websockets.

edit: I think I found the issue, I'm testing a fix now.