LemmyNet / lemmy

🐀 A link aggregator and forum for the fediverse
https://join-lemmy.org
GNU Affero General Public License v3.0
13.12k stars 863 forks source link

[Enhancment]: Add PaginationCursor for GetCommunitiesResponse (and possibly others) #4517

Open SleeplessOne1917 opened 6 months ago

SleeplessOne1917 commented 6 months ago

Requirements

Summary

The lack of pagination cursors for comments makes it impossible to fix this UI bug. It may be also useful to have pagination cursors for other list responses.

Nutomic commented 6 months ago

Turns out that this hasnt been implemented yet for comments.

SleeplessOne1917 commented 6 months ago

@Nutomic should cursor pagination be implemented for basically any response we return from the server that has a list of content (e.g. posts, comments, reports, messages, communities, users)? If this is the case, should there be a different type of PaginationCursor for each or only one (or multiple that impl a common trait)?

Nutomic commented 6 months ago

cc @dessalines @dullbananas

dullbananas commented 6 months ago

should cursor pagination be implemented for basically any response we return from the server that has a list of content (e.g. posts, comments, reports, messages, communities, users)?

Yes

should there be a different type of PaginationCursor for each or only one (or multiple that impl a common trait)?

Multiple, and I don't think a trait is needed

Sjmarf commented 2 months ago

GetPersonDetails would also benefit from this.