search

LemmyNet / lemmy

🐀 A link aggregator and forum for the fediverse
https://join-lemmy.org
GNU Affero General Public License v3.0
13.29k stars 884 forks source link

Look into replacing window alerts with toastr #457

Closed dessalines closed 4 years ago

dessalines commented 4 years ago

https://github.com/CodeSeven/toastr https://github.com/apvarun/toastify-js

dessalines commented 4 years ago

Tried one, and I love it. Looks good on mobile too.

Nutomic commented 4 years ago

Yep, looks good!

Nutomic commented 4 years ago

How about moving the alert down a few pixels so it doesnt overlap with the username and inbox button on the top right? On desktop that is.

dessalines commented 4 years ago

I could change the position to center, that's how it looks on mobile anyway. https://github.com/apvarun/toastify-js#documentation

Would that work?

Nutomic commented 4 years ago

You mean top left? That also sounds annoying. Would be better to put it somewhere without any content if possible (meaning the empty bars left and right of the content, below the header).

dessalines commented 4 years ago

Toasts are an overlay, I can only do the positions in those docs: left, center or right

Nutomic commented 4 years ago

No margin? Thats annoying then. Bottom right or bottom left would be fine on desktop though.

dessalines commented 4 years ago

K, trying bottom left now. Its deployed to dev now.